Re: [PATCH v5 3/3] drivers: Make ioapic_sbdf and hpet_sbdf contain pci_sbdf_t

[Andriy Sultanov <sultanovandriy@xxxxxxxxx>]

On 7/21/25 7:25 AM, Jan Beulich wrote:

> On 19.07.2025 00:03, dmkhn@xxxxxxxxx wrote:
> > On Thu, Jul 17, 2025 at 08:31:27AM +0100, Andrii Sultanov wrote:
> >       
> > > @@ -335,20 +336,19 @@ void cf_check amd_iommu_ioapic_update_ire(
> > >      new_rte.raw = rte;
> > >
> > >      /* get device id of ioapic devices */
> > > -    bdf = ioapic_sbdf[idx].bdf;
> > > -    seg = ioapic_sbdf[idx].seg;
> > > -    iommu = find_iommu_for_device(PCI_SBDF(seg, bdf));
> > > +    sbdf = ioapic_sbdf[idx].sbdf;
> > > +    iommu = find_iommu_for_device(sbdf);
> > >      if ( !iommu )
> > >      {
> > >          AMD_IOMMU_WARN("failed to find IOMMU for IO-APIC @ %04x:%04x\n",
> > >         
> >                                                                 ^^
> > Use %pp ?
> >       
> Here I'm pretty firmly against. We're talking of an IO-APIC here, not really
> a PCI device (and that's irrespective of AMD often(?) representing IO-APICs
> also as PCI devices).
>
> Jan
>

Please note that this one was just reverted in V5 following some review
comments. From the changelog in the commit message:
>  * Reverted print formatting change in amd_iommu_ioapic_update_ire