Re: [Xen-devel] [PATCH OSSTEST v3 1/2] examine: detect IOMMU availability and add it as a hostflag

[Ian Jackson <ian.jackson@xxxxxxxxxx>]

Roger Pau Monne writes ("[PATCH OSSTEST v3 1/2] examine: detect IOMMU 
availability and add it as a hostflag"):
> Introduce a new test to check for iommu availability and add it as a
> hostflag if found.

I regret to have to say that you seem to have overlooked my emailed
review comments on v2.  Did you receive them ?
  Subject: Re: [PATCH OSSTEST v2 1/2] examine: detect IOMMU availability and 
add it as a hostflag
  Date: Tue, 10 Mar 2020 15:51:34 +0000
  Message-ID: <24167.46982.390819.472400@xxxxxxxxxxxxxxxxxxxxxxxx>

Please could you find that mail and address my comments.

(As you do that, please make sure that you combine set_flag and
remove_flag into one function which takes a boolean parameter.  I
already asked for the boolean parameter in v2.)

(There was also a reply to v2 2/2.  I haven't looked at v3 2/2 to see
if you addressed those comments.)

Sorry,
Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel