Re: [Xen-devel] [PATCH v5 2/8] xen/arm: export device_tree_get_reg and device_tree_get_u32

[Julien Grall <Julien.Grall@xxxxxxx>]

Hi,

On 25/09/2019 19:49, Stefano Stabellini wrote:
> They'll be used in later patches.
> 
> Signed-off-by: Stefano Stabellini <stefanos@xxxxxxxxxx>

Acked-by: Julien Grall <julien.grall@xxxxxxx>

Cheers,

> 
> ---
> Changes in v5:
> - move declarations to xen/include/asm-arm/setup.h
> 
> Changes in v4:
> - new patch
> ---
>   xen/arch/arm/bootfdt.c      | 8 ++++----
>   xen/include/asm-arm/setup.h | 6 ++++++
>   2 files changed, 10 insertions(+), 4 deletions(-)
> 
> diff --git a/xen/arch/arm/bootfdt.c b/xen/arch/arm/bootfdt.c
> index 623173bc7f..a7810abb15 100644
> --- a/xen/arch/arm/bootfdt.c
> +++ b/xen/arch/arm/bootfdt.c
> @@ -55,15 +55,15 @@ static bool __init device_tree_node_compatible(const void 
> *fdt, int node,
>       return false;
>   }
>   
> -static void __init device_tree_get_reg(const __be32 **cell, u32 
> address_cells,
> -                                       u32 size_cells, u64 *start, u64 *size)
> +void __init device_tree_get_reg(const __be32 **cell, u32 address_cells,
> +                                u32 size_cells, u64 *start, u64 *size)
>   {
>       *start = dt_next_cell(address_cells, cell);
>       *size = dt_next_cell(size_cells, cell);
>   }
>   
> -static u32 __init device_tree_get_u32(const void *fdt, int node,
> -                                      const char *prop_name, u32 dflt)
> +u32 __init device_tree_get_u32(const void *fdt, int node,
> +                               const char *prop_name, u32 dflt)
>   {
>       const struct fdt_property *prop;
>   
> diff --git a/xen/include/asm-arm/setup.h b/xen/include/asm-arm/setup.h
> index efcba545c2..fa0a8721b2 100644
> --- a/xen/include/asm-arm/setup.h
> +++ b/xen/include/asm-arm/setup.h
> @@ -115,6 +115,12 @@ const char *boot_module_kind_as_string(bootmodule_kind 
> kind);
>   extern uint32_t hyp_traps_vector[];
>   void init_traps(void);
>   
> +void device_tree_get_reg(const __be32 **cell, u32 address_cells,
> +                         u32 size_cells, u64 *start, u64 *size);
> +
> +u32 device_tree_get_u32(const void *fdt, int node,
> +                        const char *prop_name, u32 dflt);
> +
>   #endif
>   /*
>    * Local variables:
> 

-- 
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel