Re: [Xen-devel] [PATCH v3 4/6] vpt: split part of pt_intr_post into a separate helper

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 08.06.18 at 17:07, <roger.pau@xxxxxxxxxx> wrote:
> No functional change.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@xxxxxxxxxx>

Assuming a subsequent patch re-uses the function
Acked-by: Jan Beulich <jbeulich@xxxxxxxx>

It would be nice though to convert ...

> --- a/xen/arch/x86/hvm/vpt.c
> +++ b/xen/arch/x86/hvm/vpt.c
> @@ -265,6 +265,41 @@ static void pt_timer_fn(void *data)
>      pt_unlock(pt);
>  }
>  
> +static void pt_irq_fired(struct vcpu *v, struct periodic_time *pt)
> +{
> +    pt->irq_issued = 0;

... this and ...

> +    if ( pt->one_shot )
> +    {
> +        if ( pt->on_list )
> +            list_del(&pt->list);
> +        pt->on_list = 0;

... this to "false" in the course of moving the code. Once again an
adjustment that perhaps can be done while committing.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxxx
https://lists.xenproject.org/mailman/listinfo/xen-devel