Re: [Xen-devel] [PATCH v1] x86/hvm: Expose MSR_SHADOW_GS_BASE

[Razvan Cojocaru <rcojocaru@xxxxxxxxxxxxxxx>]

On 01.09.2017 13:55, Andrew Cooper wrote:
> On 01/09/17 11:44, Alexandru Isaila wrote:
> > diff --git a/xen/include/public/arch-x86/hvm/save.h 
> > b/xen/include/public/arch-x86/hvm/save.h
> > index fd7bf3f..e6e8e87 100644
> > --- a/xen/include/public/arch-x86/hvm/save.h
> > +++ b/xen/include/public/arch-x86/hvm/save.h
> > @@ -134,6 +134,8 @@ struct hvm_hw_cpu {
> >       /* msr for em64t */
> >       uint64_t shadow_gs;
> >   
> > +    uint64_t shadow_gs_base;
> > +
> You presumably haven't tried migrating across this boundary?  (Things
> will explode rather impressively when you try to restore LSTAR into SMASK.)
>
> What's wrong with the shadow_gs in context here?
Nothing, we've missed that, while grepping xen/ for MSR_SHADOW_GS_BASE 
and 0xc0000102. My fault, should have checked more thoroughly. Apologies.

Thanks,
Razvan

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel