Re: [Xen-devel] [PATCH] x86/vm_event: Added support for VM_EVENT_REASON_INTERRUPT

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 09.11.16 at 12:49, <andrew.cooper3@xxxxxxxxxx> wrote:
> On 09/11/16 11:32, Razvan Cojocaru wrote:
>> On 11/09/2016 01:17 PM, Jan Beulich wrote:
>>>>>> On 09.11.16 at 10:42, <rcojocaru@xxxxxxxxxxxxxxx> wrote:
>>>> @@ -259,6 +266,13 @@ struct vm_event_cpuid {
>>>>      uint32_t _pad;
>>>>  };
>>>>  
>>>> +struct vm_event_interrupt {
>>>> +    uint32_t vector;
>>>> +    uint32_t type;
>>>> +    uint32_t error_code;
>>>> +    uint64_t cr2;
>>>> +};
>>> This being x86-specific, I think it should be named or union-ized
>>> accordingly.
>> Right, I'll rename it.
> 
> You area also exposing  X86_EVENTTYPE_* in the hypervisor ABI.
> 
> This is probably fine as it is an ABI inherited from VT-x/SVM (and by
> some miracle, are actually compatible), but you do need to move the
> constants into the public API as well.

I was about to make that comment too, but then checked: These
constants are already exposed (via the inject trap hypercall). While
moving them into the public header might be a good idea in general,
I don't think that belongs into this patch.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel