Re: [Xen-devel] [PATCH v2 6/7] xenstore: add support for reading directory with many children

[Juergen Gross <jgross@xxxxxxxx>]

On 27/10/16 17:00, Juergen Gross wrote:
> On 27/10/16 15:56, Jan Beulich wrote:
>>>>> On 27.10.16 at 11:55, <JGross@xxxxxxxx> wrote:
>>> +   /* Offset behind list: just return a list with an empty string. */
>>> +   if (off >= node->childlen) {
>>
>> Is it perhaps worth separating the == and > cases? The former is
>> just EOL, while the latter is really an error.
> 
> Hmm, yes. I'll modify it.

On a second thought: this might be the result of a concurrent
child removal. So the caller would have no chance to avoid this
situation, but he would see a different generation count in the
response.

I think I leave it as it is.


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel