Re: [Xen-devel] [PATCH v7 08/15] hvmloader: Locate the BIOS blob

[Andrew Cooper <andrew.cooper3@xxxxxxxxxx>]

On 28/07/16 11:50, Anthony PERARD wrote:
> @@ -293,8 +340,17 @@ int main(void)
>      }
>  
>      printf("Loading %s ...\n", bios->name);
> -    if ( bios->bios_load )
> -        bios->bios_load(bios);
> +    bios_module = get_module_entry(hvm_start_info, "firmware");
> +    if ( bios_module && bios->bios_load )
> +    {
> +        uint32_t paddr = bios_module->paddr;
> +
> +        bios->bios_load(bios, (void*)paddr, bios_module->size);
> +    }
> +    else if ( bios->bios_load )
> +    {
> +        bios->bios_load(bios, NULL, 0);

This is an unnecessary change in behaviour.  Currently, 'bios' is never
NULL, and would never pass bogus information to bios_load.

As this is the new way of providing firmware, it should be a hard error
if get_module_entry(, "firmware") fails, at which point this logic can
collapse down quite a lot.

~Andrew

> +    }
>      else
>      {
>          BUG_ON(bios->bios_address + bios->image_size >
>


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel