Re: [Xen-devel] [PATCH v1] hvmloader, pci: Don't try to relocate memory if 64-bit BAR is bigger than 4GB

[Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>]

> > +            {
> > +                /* If bigger than 4GB, don't try to put under 4GB. */
> > +                if ( is_64bar && bar_sz > (1ull<<32) )
> 
> Clearly at the very least this should be >=. However, even when
> it's a 2Gb BAR, we won't be able to fit it (as it can't go at address
> zero, nor at address 0x80000000, both for different reasons).

<nods>
.. snip..
> > @@ -451,7 +462,10 @@ void pci_setup(void)
> >                  resource = &mem_resource;
> >                  bar_data &= ~PCI_BASE_ADDRESS_MEM_MASK;
> >              }
> > -            mmio_total -= bar_sz;
> > +            if ( bars[i].is_64bar && bar_sz > (1ull<<32) )
> 
> Now that you use this constant a second time, it clearly needs to
> become a #define.

Do you have a preference on the ull? Most of the code has ull but there
are two instances of ULL?

> 
> Jan
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
https://lists.xen.org/xen-devel