Re: [Xen-devel] [OSSTEST PATCH V2] More Debian HVM testcases

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Wei Liu writes ("[OSSTEST PATCH V2] More Debian HVM testcases"):
> ts-debain-hvm-install was written to work as general HVM testcase. It
> can be tuned to easily use another BIOS other than OVMF.
> 
> Modify make-flight and friends to create more Debian HVM 64bit testcases
> to run with SeaBIOS and ROMBIOS.

Thanks.

> +  if [ "x$qemuu_suffix" == "x-qemuu" ]; then
> +    # QEMU upstream supports ovmf and seabios
> +    job_create_test test-$xenarch$kern-$dom0arch-xl$qemuu_suffix-ovmf-amd64 \
> +      test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
> +      debianhvm_image=debian-7.2.0-amd64-CD-1.iso \
> +      bios=ovmf \
> +      all_hostflags=$most_hostflags,hvm
> +
> +    job_create_test 
> test-$xenarch$kern-$dom0arch-xl$qemuu_suffix-debianhvm-amd64 \
> +      test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
> +      debianhvm_image=debian-7.2.0-amd64-CD-1.iso \
> +      bios=seabios \
> +      all_hostflags=$most_hostflags,hvm
> +  else
> +    # QEMU traditional supports rombios
> +    job_create_test 
> test-$xenarch$kern-$dom0arch-xl$qemuu_suffix-debianhvm-amd64 \
> +      test-debianhvm xl $xenarch $dom0arch $qemuu_runvar \
> +      debianhvm_image=debian-7.2.0-amd64-CD-1.iso \
> +      bios=rombios \
> +      all_hostflags=$most_hostflags,hvm
> +  fi

There's a lot of repetition here, which I think ought to be abstracted
away.

But by and large this looks good.  The changes to ts-debianhvm-install
and sg-run-job seem fine to me.

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel