Re: [Xen-devel] [PATCH] tmem: propagate ENOMEM result in error handling

[Bob Liu <bob.liu@xxxxxxxxxx>]

On 03/29/2014 01:07 PM, Matthew Daley wrote:
> ...otherwise if pcd_associate fails due to out-of-memory, the caller of
> do_tmem_put will think the call was successful.
> 

Good catch! Thanks a lot!

> While at it, fix up the style issue.
> 
> Signed-off-by: Matthew Daley <mattd@xxxxxxxxxxx>

Reviewed-by: Bob Liu <bob.liu@xxxxxxxxxx>

> ---
>  xen/common/tmem.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/xen/common/tmem.c b/xen/common/tmem.c
> index 02e7e2e..9cebe11 100644
> --- a/xen/common/tmem.c
> +++ b/xen/common/tmem.c
> @@ -1646,8 +1646,11 @@ copy_uncompressed:
>  
>      if ( tmem_dedup_enabled() && !is_persistent(pool) )
>      {
> -        if ( pcd_associate(pgp,NULL,0) == -ENOMEM )
> +        if ( pcd_associate(pgp, NULL, 0) == -ENOMEM )
> +        {
> +            ret = -ENOMEM;
>              goto del_pgp_from_obj;
> +        }
>      }
>  
>  insert_page:
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel