Re: [Xen-devel] [PATCH v2 2/5] VMX: Turn on posted interrupt bit in vmcs

["Zhang, Yang Z" <yang.z.zhang@xxxxxxxxx>]

Jan Beulich wrote on 2013-04-17:
>>>> On 17.04.13 at 08:50, Yang Zhang <yang.z.zhang@xxxxxxxxx> wrote:
>> --- a/xen/arch/x86/hvm/vmx/vmcs.c
>> +++ b/xen/arch/x86/hvm/vmx/vmcs.c
>> @@ -926,6 +926,12 @@ static int construct_vmcs(struct vcpu *v)
>>          __vmwrite(GUEST_INTR_STATUS, 0);
>>      }
>> +    if ( cpu_has_vmx_posted_intr_processing ) +    { +       
>> __vmwrite(PI_DESC_ADDR, virt_to_maddr(&v->arch.hvm_vmx.pi_desc)); +    
>>    __vmwrite(POSTED_INTR_NOTIFICATION_VECTOR,
> POSTED_INTERRUPT_VECTOR);
> 
> Shouldn't this be posted_intr_vector?
Yes, it should be posted_intr_vector.
>
> 
>> --- a/xen/include/asm-x86/mach-default/irq_vectors.h
>> +++ b/xen/include/asm-x86/mach-default/irq_vectors.h
>> @@ -9,12 +9,13 @@
>>  #define CALL_FUNCTION_VECTOR        0xfb #define LOCAL_TIMER_VECTOR 0xfa
>>  #define PMU_APIC_VECTOR     0xf9 +#define POSTED_INTERRUPT_VECTOR   0xf8 /*
>>   * High-priority dynamically-allocated vectors. For interrupts that
>>   * must be higher priority than any guest-bound interrupt.
>>   */
>>  #define FIRST_HIPRIORITY_VECTOR     0xf1
>> -#define LAST_HIPRIORITY_VECTOR  0xf8
>> +#define LAST_HIPRIORITY_VECTOR  0xf7
>>  /* IRQ0 (timer) is statically allocated but must be high priority. */
>>  #define IRQ0_VECTOR             0xf0
> 
> And these changes should both no longer be necessary.
> 
> Or am I mis-reading "Allocate posted interrupt vector dynamically"
> in your overview mail?
No, you are right. I may send the wrong patch. This is removed actually. I will 
resend it in version 3.

Best regards,
Yang



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel