Re: [Xen-devel] [PATCH 13/18 V2]: PVH xen: introduce p2m_map_foreign

["Jan Beulich" <JBeulich@xxxxxxxx>]

>>> On 16.03.13 at 01:51, Mukesh Rathor <mukesh.rathor@xxxxxxxxxx> wrote:
> @@ -1307,6 +1309,11 @@ void arch_get_info_guest(struct vcpu *v, 
> vcpu_guest_context_u c)
>              c.nat->gs_base_kernel = hvm_get_shadow_gs_base(v);
>          }
>      }
> +    else if ( is_pvh_vcpu(v) )
> +    {
> +        /* fixme: punt it to phase II */
> +        printk("PVH: fixme: arch_get_info_guest()\n");
> +    }

This has hardly anything to do with the patch at hand.

> @@ -430,7 +431,7 @@ ept_set_entry(struct p2m_domain *p2m, unsigned long gfn, 
> mfn_t mfn,
>      }
>  
>      /* Track the highest gfn for which we have ever had a valid mapping */
> -    if ( p2mt != p2m_invalid &&
> +    if ( p2mt != p2m_invalid && p2mt != p2m_mmio_dm &&

Considering the subject of the patch, was this perhaps meant to be
p2m_map_foreign?

> @@ -429,7 +430,7 @@ p2m_set_entry(struct p2m_domain *p2m, unsigned long gfn, 
> mfn_t mfn,
>      }
>  
>      /* Track the highest gfn for which we have ever had a valid mapping */
> -    if ( p2mt != p2m_invalid
> +    if ( p2mt != p2m_invalid && p2mt != p2m_mmio_dm

Same here.

> --- a/xen/arch/x86/physdev.c
> +++ b/xen/arch/x86/physdev.c
> @@ -475,6 +475,12 @@ ret_t do_physdev_op(int cmd, 
> XEN_GUEST_HANDLE_PARAM(void) arg)
>  
>      case PHYSDEVOP_set_iopl: {
>          struct physdev_set_iopl set_iopl;
> +
> +        if ( is_pvh_vcpu(current) ) {
> +            ret = -EINVAL;
> +            break;
> +        }
> +

Again unrelated to the subject of the patch.

> @@ -488,6 +494,8 @@ ret_t do_physdev_op(int cmd, XEN_GUEST_HANDLE_PARAM(void) 
> arg)
>  
>      case PHYSDEVOP_set_iobitmap: {
>          struct physdev_set_iobitmap set_iobitmap;
> +
> +        ASSERT( !is_pvh_vcpu(current) );

Again.

Jan


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel