Re: [Xen-devel] [PATCHv3] QEMU(upstream): Disable xen's use of O_DIRECT by default as it results in crashes.

[Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>]

Stefano Stabellini writes ("Re: [PATCHv3] QEMU(upstream): Disable xen's use of 
O_DIRECT by default as it results in crashes."):
> On Fri, 15 Mar 2013, Ian Jackson wrote:
> > I thought you were telling me to commit it to your tree.
> 
> Right, we misunderstood each other.
> I thought you were going to commit it to qemu-xen-unstable.git

Oh I see.  I thought we already had the equivalent there.  Let me
check...

...no, we don't.  The code there is somewhat different.  How about
the patch below ?

Stefano, shall I revert the commit in qemu-upstream-unstable ?

Ian.

diff --git a/hw/xen_disk.c b/hw/xen_disk.c
index 33a5531..ee8d36f 100644
--- a/hw/xen_disk.c
+++ b/hw/xen_disk.c
@@ -635,7 +635,7 @@ static int blk_init(struct XenDevice *xendev)
        return -1;
 
     /* read-only ? */
-    qflags = BDRV_O_NOCACHE;
+    qflags = BDRV_O_CACHE_WB;
     if (strcmp(blkdev->mode, "w") == 0) {
        mode   = O_RDWR;
        qflags |= BDRV_O_RDWR;

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel