Re: [Xen-devel] [RFC PATCH V3 19/22] Enable exteneded event channel ABI query

[David Vrabel <david.vrabel@xxxxxxxxxx>]

On 27/02/13 14:34, Wei Liu wrote:
> --- a/xen/common/event_channel.c
> +++ b/xen/common/event_channel.c
> @@ -1219,12 +1219,14 @@ static long evtchn_register_extended(struct 
> evtchn_register_extended *reg)
>  
>      switch ( reg->cmd )
>      {
> -    case EVTCHN_EXTENDED_NONE:
> -    default:
> -        rc = -EINVAL;
> +    case EVTCHN_EXTENDED_QUERY:
> +        rc = extended_event_channel;
> +        break;

I don't like overloading the return value with both success/failure and
the data.

Can this info be returned in a parameter?

David

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel