Re: [Xen-devel] [PATCH 32/45] xen: arm: show_registers() support for 64-bit.

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Thu, 2013-02-14 at 14:59 +0000, Tim Deegan wrote:
> At 15:56 +0000 on 23 Jan (1358956598), Ian Campbell wrote:
> > -static void _show_registers(struct cpu_user_regs *regs,
> > -                            struct reg_ctxt *ctxt,
> > -                            int guest_mode)
> > +
> > +static void _show_registers_32(struct cpu_user_regs *regs,
> 
> Can we drop the _extraneous _underscore while we're here?

yes.
> 
> >      {
> > -        printk("     SP: %08"PRIx32" LR: %08"PRIx32"\n", regs->sp, 
> > regs->lr);
> > +        printk("SCTLR_EL1: %08"PRIx32"\n", ctxt->sctlr);
> > +        printk("  TCR_EL1: %08"PRIx32"\n",ctxt->tcr);
> 
> Missing space  ------------------------------^

ack.

> 
> > +#ifdef CONFIG_ARM_32
> >      printk("HTTBR %"PRIx64"\n", READ_CP64(HTTBR));
> >      printk("HDFAR %"PRIx32"\n", READ_CP32(HDFAR));
> >      printk("HIFAR %"PRIx32"\n", READ_CP32(HIFAR));
> >      printk("HPFAR %"PRIx32"\n", READ_CP32(HPFAR));
> >      printk("HCR %08"PRIx32"\n", READ_CP32(HCR));
> >      printk("HSR   %"PRIx32"\n", READ_CP32(HSR));
> > +    printk("VTTBR %010"PRIx64"\n", READ_CP64(VTTBR));
> >      printk("\n");
> >  
> >      printk("DFSR %"PRIx32" DFAR %"PRIx32"\n", READ_CP32(DFSR), 
> > READ_CP32(DFAR));
> >      printk("IFSR %"PRIx32" IFAR %"PRIx32"\n", READ_CP32(IFSR), 
> > READ_CP32(IFAR));
> >      printk("\n");
> > +#else
> > +    reg = READ_SYSREG64(TTBR0_EL2); printk("TTBR0_EL2: %"PRIx64"\n", reg);
> 
> Any reason this (&c) isn't printk("...", READ_SYSREG64(...)) like the
> arm32 ones?

hangover from a previous MACRO(REGISTER, variable) implementation. Will
fix.

> 
> Tim.



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxx
http://lists.xen.org/xen-devel