Re: [Xen-devel] Re: [PATCH] hw/piix_pci.c: Fix PIIX3-xen to initialize ids

[Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>]

On Wed, 22 Jun 2011, Anthony PERARD wrote:
> On Wed, Jun 22, 2011 at 18:43, Stefano Stabellini
> <stefano.stabellini@xxxxxxxxxxxxx> wrote:
> > On Wed, 22 Jun 2011, anthony.perard@xxxxxxxxxx wrote:
> >> From: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >>
> >> Signed-off-by: Anthony PERARD <anthony.perard@xxxxxxxxxx>
> >> ---
> >> Âhw/piix_pci.c | Â Â3 +++
> >> Â1 files changed, 3 insertions(+), 0 deletions(-)
> >>
> >> diff --git a/hw/piix_pci.c b/hw/piix_pci.c
> >> index 26ce904..d08b31a 100644
> >> --- a/hw/piix_pci.c
> >> +++ b/hw/piix_pci.c
> >> @@ -478,6 +478,9 @@ static PCIDeviceInfo i440fx_info[] = {
> >>     Â.no_hotplug  = 1,
> >>     Â.init     = piix3_initfn,
> >> Â Â Â Â Â.config_write = piix3_write_config_xen,
> >> +    Â.vendor_id  Â= PCI_VENDOR_ID_INTEL,
> >> +    Â.device_id  Â= PCI_DEVICE_ID_INTEL_82371SB_0, // 82371SB PIIX3 
> >> PCI-to-ISA bridge (Step A1)
> >> +    Â.class_id   = PCI_CLASS_BRIDGE_ISA,
> >> Â Â Â},{
> >> Â Â Â Â Â/* end of list */
> >> Â Â Â}
> >
> > shouldn't piix3_initfn take care of setting vendor_id, device_id and
> > class_id, as in the normal PIIX3 case?
> 
> Not anymore. These ids have been removed from piix3_initfn and added
> to the PCIDeviceInfo of PIIX3 in the last update.

I see. Good catch.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel