[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7

  • To: Jan Beulich <JBeulich@xxxxxxxxxx>, Xin Li <xin.li@xxxxxxxxx>
  • From: Keir Fraser <keir.xen@xxxxxxxxx>
  • Date: Wed, 01 Jun 2011 07:47:24 +0100
  • Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Tue, 31 May 2011 23:48:51 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=ppEBIIbdHvc/6gv+xNLy72zlMX0qsSfv/go64iUL43EKddNAMQyNnb7lBt88zYebfd jbhwKQJDEoNksZHY4IdsROJQ1LjrqD/b39XxH+b50cDebZZEuMkJIJOmZyjTirjQISRQ pUOipqk+vPTimE8R149y8yMXQntxTg9TaZbzM=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcwgJ8NXuIq+Qkwdekihnyl8xMNeHg==
  • Thread-topic: [PATCH] CPUID level 0x00000007:0 (ebx) is word 9, instead of word 7

On 01/06/2011 07:35, "Jan Beulich" <JBeulich@xxxxxxxxxx> wrote:

>>>> On 31.05.11 at 16:59, "Li, Xin" <xin.li@xxxxxxxxx> wrote:
>>> can't see why we would need to stay in sync with Linux's capability
>>> array indices.
>> why?  Typically we reuse Linux code unless Xen has its special logic.
> So you would suggest leaving indices 7 and 8 unused instead?
> Looking at current Linux, we certainly could convert Xen to use
> index 8 for virtualization features, but since these are being
> tracked differently already anyway I don't see a value in this.
> As to index 7, just look at ARAT - we're already diverging from
> Linux here (having it allocated in index 3).
> Bottom line is that I think keeping the names (and in various cases
> the grouping together, namely when the bits are grouped together
> in some CPUID leaf's output) in sync is desirable, but following
> Linux to the bit doesn't always make sense. After all, some thinking
> will always be necessary when porting over patches.


 -- Keir

> Jan

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.