[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Re: [PATCH v6] xen pci backend driver.

On Fri, 27 May 2011 11:22:20 -0400
Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:

> On Mon, Apr 25, 2011 at 11:58:50AM -0700, Jesse Barnes wrote:
> > On Wed, 20 Apr 2011 17:07:19 -0400
> > Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx> wrote:
> > 
> > > The following patch implements the Xen pci backend for upstream Linux.
> > > This is the host side counterpart to the frontend driver in
> > > drivers/pci/xen-pcifront.c. The PV protocol is also implemented by
> > > frontend drivers in other OSes too, such as the BSDs.
> > > 
> > > This driver has a long history as an out of tree driver but I am
> > > submitting it here as a single monolithic patch to aid review. Once it
> > > has been reviewed and is considered suitable for merging can we perhaps
> > > consider merging the equivalent git branch which maintains much of
> > > history?
> > 
> > It looks pretty clean at first glance (though 128k worth of patch isn't
> > an ideal way to split it).
> > 
> > But maybe the back end belongs in arch/x86/xen as it's really a arch
> > specific PCI implementation at heart?  I don't want to be a bottleneck
> > for any Xen specific PCI patches in the future, and other arches have a
> > similar split (though not always with an ideal core vs arch split).
> Jesse,
> Xen has a drivers/xen directory. In the past we have put some of the
> "backends" in there, such as the SWIOTLB one. Perhaps some of it (or all?)
> of this driver should go in there? If you are OK with this I can do it
> that way and start chasing folks to review this driver?

Yeah, I'm fine with that.  Each arch typically has a chunk of PCI code
under arch/ anyway (some more than others), so doing it that way is ok
with me.
> > Figuring out some way to preserve the git history is probably a good
> > idea, assuming it's not too much of a mess.  If it is, a more
> I tried to keep it clean.. Most of the stuff is from me thought so I might
> as well just squash it in one.

Yeah that's up to you; presumably you just want to preserve the useful
parts of the history, or maybe just make the initial changelog big
enough to include all the important bits you've learned over the
years. :)

Jesse Barnes, Intel Open Source Technology Center

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.