Re: [Xen-devel] [PATCH 1 of 8] libxc: save/restore: remove static context variables

[Vincent Hanquez <vincent.hanquez@xxxxxxxxxxxxx>]

On 05/24/2011 10:14 AM, Ian Campbell wrote:
> # HG changeset patch
> # User Ian Campbell<ian.campbell@xxxxxxxxxx>
> # Date 1306228450 -3600
> # Node ID c43bf40e2f29eb02c7dcf1a2317f243f1af5f659
> # Parent  0727b2fcc33fd5cdf847fde0d2be261be3d6b279
> libxc: save/restore: remove static context variables
>
> 20544:ad9d75d74bd5 and 20545:cc7d66ba0dad seemingly intended to change these
> global static variables into stack variables but didn't remove the static
> qualifier.
>
> Also zero the entire struct once with memset rather than clearing fields
> piecemeal in two different places.
Good catch.
Acked-by-self.

--
Vincent


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel