[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: [Xen-devel] Re: [Pkg-xen-devel] xen 4.1 blktap2 support

On Fri, 2011-05-20 at 18:08 +0100, Ian Jackson wrote:
> Ian Campbell writes ("[PATCH] Re: [Xen-devel] Re: [Pkg-xen-devel] xen 4.1 
> blktap2 support"):
> > Agreed, and anyway libxl_exec is a generic is supposed to be a generic
> > interface so having it close file handles which the caller _wants_ to
> > pass to the child is a bit unhelpful.
> > 
> > Lets try the below to start with.
> It looks good but you are missing some #includes I think:
> cc1: warnings being treated as errors
> libxl_exec.c: In function 'check_open_fds':
> libxl_exec.c:56: error: implicit declaration of function 'fcntl'
> libxl_exec.c:56: error: 'F_GETFD' undeclared (first use in this function)
> libxl_exec.c:56: error: (Each undeclared identifier is reported only once
> libxl_exec.c:56: error: for each function it appears in.)
> libxl_exec.c:64: error: 'FD_CLOEXEC' undeclared (first use in this function)

fcntl(2) says fcntl needs unistd.h (already present in source) and
fcntl.h (added by this patch). Did a hunk get rejected? I'm build
testing on Squeeze.

> libxl_exec.c: In function 'libxl__spawn_spawn':
> libxl_exec.c:175: error: 'pipes' undeclared (first use in this function)
> make: *** [libxl_exec.o] Error 1

pipes is a local variable added by this patch which should have been
reference several times by line 175... Another .rej?

Ian Campbell

The world really isn't any worse.  It's just that the news coverage
is so much better.

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.