[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c

  • To: Olaf Hering <olaf@xxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 20 May 2011 15:58:09 +0100
  • Cc: "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • Delivery-date: Fri, 20 May 2011 08:00:05 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=lc6Un3Tsncfx1ek6l2ZerBJlrVDkreuDT4vmYxeP7BVQnVa294vbEHlYLenb32apT6 waircvlGt0Ab+NWnLN2qjPUgwVsaoC6zZhSCgn+vO5PGonh1fHeN4NWMtqJkxh33iEKp Be0ZXRWQfyVlhF1G1HSzCq+h+cUkNXCt6lX+k=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcwW/lT4mGjL2HTfmES41ns87vB/sg==
  • Thread-topic: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c

On 20/05/2011 15:38, "Olaf Hering" <olaf@xxxxxxxxx> wrote:

> On Fri, May 20, Keir Fraser wrote:
>> On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:
>>>> I applied the first couple of these patches, but... We don't set
>>>> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
>>>> we? Unless they are cleanups or fixes in some other way?
>>> gcc 4.6 adds it to the default set of Werrors.
>> I'll take a patch from someone to remove it from the default set, please.
> I will send a tested patch.
> It may hide some bugs. In one of the patches for tools/ some function
> returns 0 unconditionally instead of the rc variable.

Oh dear. Well, the tools/libxl maintainers are free to keep the new
warnings, and take your fixes, if they wish, clearly needing the help. ;-)

 -- Keir

> Olaf

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.