[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c

  • To: Ian Campbell <Ian.Campbell@xxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxx>
  • Date: Fri, 20 May 2011 09:41:34 +0100
  • Cc: Olaf Hering <olaf@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • Delivery-date: Fri, 20 May 2011 01:42:20 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:user-agent:date:subject:from:to:cc:message-id:thread-topic :thread-index:in-reply-to:mime-version:content-type :content-transfer-encoding; b=b0UHs+qdC3pTqUz8qvqsC+7Xjovim/SIvoxLjPgG8dyDgepT7TDgUr/OflI8Ku0W5r w2p2MIDkTJ4HW0gd/HtnBCoe4VTeO44pVCFYF+Wnlt7XENjFMUPVTy2ByPl0xwzFslAG 0lQxB62dYghWsVhMpfTUsv5+B2plfHw597wx8=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: AcwWyblNvMjM/J3zK0ypxm3xHanOXw==
  • Thread-topic: [Xen-devel] [PATCH 03 of 45] gcc-4.6 compile fix: tools/xenstore/xenstored_core.c

On 20/05/2011 09:30, "Ian Campbell" <Ian.Campbell@xxxxxxxxxx> wrote:

>> I applied the first couple of these patches, but... We don't set
>> -Werror=unused-but-set-variable, so we don't actually need these fixes, do
>> we? Unless they are cleanups or fixes in some other way?
> gcc 4.6 adds it to the default set of Werrors.

I'll take a patch from someone to remove it from the default set, please.
Until plenty of people are using gcc 4.6, it'll only get broken again and
again anyway, even if we applied all the current fixes.

I've applied all the patches that I considered nice cleanups, I'd like to
drop the rest.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.