Re: [Xen-devel] [PATCH] retry instruction on svm emulation failure

[Wei Huang <wei.huang2@xxxxxxx>]

I don't think we can take this patch before understanding what is going 
on. As Keir said, could you share a sample code or failure case? so we 
can debug it.
Thanks,
-Wei

On 05/18/2011 05:08 AM, Keir Fraser wrote:
> On 18/05/2011 10:05, "Paolo Bonzini"<pbonzini@xxxxxxxxxx>  wrote:
>
> > retry instruction on svm emulation failure
> >
> > Upon emulation failure, Xen injects a #GP into the guest on AMD machines.
> > However, this kind of #GP does not happen in hardware.  It is possible
> > (and was observed in practice) that the failure is transient.  It will
> > go away naturally if the instruction is retried, because the guest will
> > be executing other code and will not exit.
> It begs the question why we were emulating the instruction in the first
> place. I'd like to see further explanation, with a concrete example, before
> applying this patch. Or get an Ack from an AMD maintainer.
>
>   -- Keir
>
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel