[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] use compat_*() for all 32-bit hypercalls.

  • To: xen-devel@xxxxxxxxxxxxxxxxxxx
  • From: George Dunlap <George.Dunlap@xxxxxxxxxxxxx>
  • Date: Tue, 10 May 2011 16:25:29 +0100
  • Delivery-date: Tue, 10 May 2011 08:26:15 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=sWAL+YYyOj8Nzog7OnhXh5KfdxqNiiv+GQlhZ/YETgxQGtFrKbO1AhuZZecQZe3AQF bOb+XC1ZxHQ671I+kircT3De+1SFP5zBuD1pTPmCOEUKfzd93V6+mg3fGk/XCBrN+tN9 LstgD7dHrA//eYRc6wXUsD/hC+onqwq9DxNXo=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

Is this a problem for 4.1 as well, or are the lockups in HVMloader
xenbus in code that's been introduced since then?


On Tue, May 10, 2011 at 1:55 PM, Tim Deegan <Tim.Deegan@xxxxxxxxxx> wrote:
> The attached patch switches the handling of sched_op, get_xen_version
> and set_timer_op hypercalls from 32-bit HVM guests to use the compat
> versions of the handlers.  As far as I can see this is correcting an
> oversight: other hypercalls are already redirected to the compat
> versions and having a mix of translated and untranslated seems like the
> worst option.
> The only one of these three that's likely to cause trouble is schedop
> (poll) which almost always happens to work if you call the wrong
> version.  However the interlock against concurrent event arrival
> doesn't work, which was leading to lockups in the HVMloader xenbus code.
> Cc'ing various people who I know are responsible for HVM PV drivers just
> in case any ofthem have hardcoded this broken interface into client
> code.
> Cheers,
> Tim.
> --
> Tim Deegan <Tim.Deegan@xxxxxxxxxx>
> Principal Software Engineer, Xen Platform Team
> Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.