[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] Fwd:[PATCH-may be a bug ignored] tools/libxl/libxl__build_device_model_args_new/old: The condition is so rigorous that user has no chance to disable the vnc


  • To: Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>
  • From: ZhouPeng <zpengxen@xxxxxxxxx>
  • Date: Tue, 10 May 2011 19:05:02 +0800
  • Cc: "Xen-Devel \(E-mail\)" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • Delivery-date: Tue, 10 May 2011 04:06:03 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type:content-transfer-encoding; b=ns5Gt3MEjN/B+8E/AWxS3Sur9loTbi8eSTFbG42QxZuE/IADj8J7Ixj7DFPCXTbIt0 N1rd5Rvp+1QV7nMKFsRD41T6vGL1ZO3YSBYgCl2F1yL8oLpQnJaeIg9p5GJmYM23OQ+u mwJEnypd5rzhAfftA/XAPbUIJl04rwEgRL63A=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

2011/5/9 Ian Jackson <Ian.Jackson@xxxxxxxxxxxxx>:
> ZhouPeng writes ("[Xen-devel] Fwd:[PATCH-may be a bug ignored] 
> tools/libxl/libxl__build_device_model_args_new/old: The condition is so 
> rigorous that user has no chance to disable the vnc"):
>> In my spice testing,
>> I find user have no way to disable vnc in qemu-old and new using xl,
>> no matter how to set
>> "vnc vncunused vncpasswd vncdisplay vnclisten" in vm cfg file.
>
> Does your patch not have the effect of turning vnc off by default ?  I
> don't think that's correct.

pls see below:
parse_config_data(...)  < xl_cmdimpl.c >
       libxl_init_dm_info(...) set dm_info->vnc = 1
       ...
       if (!xlu_cfg_get_long(config, "vnc", &l))
                dm_info->vnc = l

So, The patch will turn vnc off  by default,
Because dm_info->vnc = 1 in libxl_init_dm_info(...) turn on vnc in default,
My patch turns off vnc only when user 'set vnc = 0' explicitly in vm cfg file.

And testing in xen-unstable, it works.

Thanks,
> Ian.
>



-- 
Zhou Peng
Operating System Technology Group
Institute of Software, the Chinese Academy of Sciences (ISCAS)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.