[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] libxl: virtio-blk-pci support for FV domain

  • To: Wei Liu <liuw@xxxxxxxxx>, Xen Devel <Xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Takeshi HASEGAWA <hasegaw@xxxxxxxxx>
  • Date: Sun, 8 May 2011 20:26:16 +0900
  • Cc: Anthony PERARD <anthony.perard@xxxxxxxxxx>, Stefano Stabellini <stefano.stabellini@xxxxxxxxxxxxx>
  • Delivery-date: Sun, 08 May 2011 04:26:57 -0700
  • Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :cc:content-type; b=p/1Vt3lwXDp4hg6WChd4zi6nItiVGtp06x+6a6lIqNNxvycROodtAav3JSUWPDeYCn R4nEkHkEMs7R4WXPABgpfieRvewGDiNuleUadTDysmIbJ9+sJQ2vNdDqq4SbEvUIGOzi moJ9T7ao7bqkRtTr8YMA8seFESTDolV6085I4=
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>

My patch threats virtio block devices with same manner with xvd, sd, and hd.
Though, I need to discuss with xen developpers whether the vbd number
assignment is reasonable or not.

I guess blktap and blkback will never handle virto block device, so assigning
(reserving) the whole range of 2 << 28 for virtio block vbd may be more better.

Actually virtio is not Xen's VBD, so vbd number is not mandatory to work.
However, I believe this approach makes virtio block manageable
in same way as xvd and others.

I am looking forward for xen developpers' opinions.


2011/05/08 14:25 "Wei Liu" <liuw@xxxxxxxxx>:
> On Sun, May 8, 2011 at 12:56 PM, Wei Liu <liuw@xxxxxxxxx> wrote:
>> Thanks, I just started working on VirtIO block support yesterday.
>> I was trying to add support to parse_disk_config() so that we can
>> specify "-if" option in the config file.
>> I'm wondering which approach is better -- configure through
>> device_virtdisk_matches() or parse_disk_config() .
>> Any suggestions?
> It seems that Takeshi's approach is better.
> I should follow libxl's conventions.
> --
> Best regards
> Wei Liu
> Twitter: @iliuw
> Site: http://liuw.name

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.