Re: [Xen-devel] [PATCH] blkfront: fix data size for xenbus_gather in, blkfront_connect

[Ian Campbell <Ian.Campbell@xxxxxxxxxx>]

On Mon, 2011-05-02 at 12:06 +0100, Marek Marczykowski wrote:
> barrier variable is int, not long. This overflow caused another variable
> override: "err" (in PV code) and "binfo" (in xenlinux code -
> drivers/xen/blkfront/blkfront.c). The later caused incorrect device
> flags (RO/removable etc).
> 
> Signed-off-by: Marek Marczykowski <marmarek@xxxxxxxxxxxx>

Good catch.

Acked-by: Ian Campbell <ian.campbell@xxxxxxxxxx>

> ---
>  drivers/block/xen-blkfront.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/block/xen-blkfront.c b/drivers/block/xen-blkfront.c
> index 70f3b1b..6147a4e 100644
> --- a/drivers/block/xen-blkfront.c
> +++ b/drivers/block/xen-blkfront.c
> @@ -1151,7 +1151,7 @@ static void blkfront_connect(struct blkfront_info
> *info)
>       }
> 
>       err = xenbus_gather(XBT_NIL, info->xbdev->otherend,
> -                         "feature-barrier", "%lu", &barrier,
> +                         "feature-barrier", "%d", &barrier,
>                           NULL);
> 
>       /*
> 



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel