[Xen-devel] Re: [PATCH] Unmmap guest's EPT mapping for poison memory

[Tim Deegan <Tim.Deegan@xxxxxxxxxx>]

At 10:19 +0100 on 13 Sep (1284373193), Jiang, Yunhong wrote:
> I'm not sure if the change to the _gfn_to_mfn_type() is
> acceptable. Especially, if it is right to change the mfn to be
> INVALID_MFN. The idea to change the mfn to be INVALID_MFN is, we don't
> need to change every caller for broken type (I noticed the PoD/sharing
> etc checked each caller), but depends on caller will check the mfn to
> be valid or not.

That's fine.  All callers _should_ check the type but there's no harm in
changing the mfn as a double precaution, even if everything else was right.

Acked-by: Tim Deegan <Tim.Deegan@xxxxxxxxxx>

-- 
Tim Deegan <Tim.Deegan@xxxxxxxxxx>
Principal Software Engineer, XenServer Engineering
Citrix Systems UK Ltd.  (Company #02937203, SL9 0BG)

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel