Re: [Xen-devel] Re: [PATCH] Remus breaks the build

[Brendan Cully <brendan@xxxxxxxxxx>]

On Friday, 13 August 2010 at 12:44, Brendan Cully wrote:
> On Friday, 13 August 2010 at 13:52, Ian Jackson wrote:
> > Stefano Stabellini writes ("[Xen-devel] Re: [PATCH] Remus breaks the 
> > build"):
> > > I'll apply the patch for now, of course I am more then willing to
> > > re-enable remus as soon as the problem is fixed.
> > 
> > Quite so.  I have also removed remus from the nightly tests (since
> > otherwise this would be regarded as a regression in the cases where
> > remus still sort of worked; it hasn't worked properly for some time).
> 
> As always, Ian, it would be better if you provided some kind of
> concrete bug report instead vaguely saying "it doesn't work". I've
> never received one.

It turns out it was broken... by you, in 21488:dd6bbdc42033 (I missed
this because I've been running the 4.0 tree until recently). That
patch of yours only appeared to be a no-op, because it missed several
calls to read_exact. I've patchbombed the fix.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel