Re: [Xen-devel] [PATCH] HVM vcpu hotplug: Fix acpi method NTFY bug

[Keir Fraser <keir.fraser@xxxxxxxxxxxxx>]

On 27/01/2010 05:33, "Liu, Jinsong" <jinsong.liu@xxxxxxxxx> wrote:

> HVM vcpu hotplug: Fix acpi method NTFY bug
> 
> Cancel define method NTFY by using decision_tree, it will block vcpu add and
> result in other unpredicted error. The second reason is method NTFY is not key
> path and no necessary using complicated decision_tree to reduce scan time. The
> third reason is, the scan loop defined by method PRSC is not necessary equal
> to the scan loop defined by method NTFY, and not necessary equal to 2^n.
> 
> Signed-off-by: Liu, Jinsong <jinsong.liu@xxxxxxxxx>

You'll have to point out how this fixes the NTFY method I'm afraid -- the
two methods look exactly equivalent to me, except the existing method should
on average execute with far fewer compares, and hence looks preferable.

And please don't send updates to dsdt.c in patches which update DSDT. I
always re-generate it myself anyway, and it makes your patch 1000x bigger.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel