Re: [Xen-devel] [patch] xend: pass slot for pass-through devices to qemu-xen

[Simon Horman <horms@xxxxxxxxxxxx>]

I would like to withdraw this patch for now as
it partially breaks hotplug. I will try to come up
with a better solution and post it soon.

On Mon, Mar 23, 2009 at 08:56:39PM +1100, Simon Horman wrote:
> My patch "xend: specify the slot for pass-through devices"
> which was included in xen-unstable.hg as changeset 19418:538a64b1ed63
> had an omission.
> 
> The code included parsing of slots from the configuration file.
> And it stored this information in xend. However, it failed
> to pass this information on to qemu-xen.
> 
> The patch that was posted and applied doesn't break anything, it just
> doesn't achieve anything either.
> 
> Apologies for this omission, it was removed to test
> possible regressions, and unfortunately wasn't replaced
> in the version that I posted.
> 
> Signed-off-by: Simon Horman <horms@xxxxxxxxxxxx>
> 
> --- 
> 
> There are qemu-xen companion patches for this change which have been
> posted as "ioemu: specify the slot for pass-through devices"
> 
> Index: xen-unstable.hg/tools/python/xen/xend/server/pciif.py
> ===================================================================
> --- xen-unstable.hg.orig/tools/python/xen/xend/server/pciif.py        
> 2009-03-23 19:55:21.000000000 +1100
> +++ xen-unstable.hg/tools/python/xen/xend/server/pciif.py     2009-03-23 
> 20:24:36.000000000 +1100
> @@ -87,8 +87,8 @@ class PciController(DevController):
>              if vslt is not None:
>                  vslots = vslots + vslt + ";"
>  
> -            back['dev-%i' % pcidevid] = "%04x:%02x:%02x.%01x" % \
> -                                        (domain, bus, slot, func)
> +            back['dev-%i' % pcidevid] = "%04x:%02x:%02x.%01x@%02x" % \
> +                                        (domain, bus, slot, func, vslot)
>              back['uuid-%i' % pcidevid] = pci_config.get('uuid', '')
>              pcidevid += 1
>  
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel