Re: [Xen-devel] qemu-xen: build problem with chang-set "passthrough: make management of PCI D-states by guest optional"

[Kouya Shimura <kouya@xxxxxxxxxxxxxx>]

Hi Simon,

I have no problem here. See the attached log of "touch xenstore.c; make -n".
xenstore.o is certainly linked.

Thanks,
Kouya

Simon Horman writes:
> Hi,
> 
> I am seeing the following build problem on x86_64 in the
> current HEAD (c6cca375a2fc681726b7c1e0e37dbc0a4f354032
> "More stubdom build fixes"). The problem seems to
> have been introduced by (c78b0e0b65d65d0f84b1027344667366064a0a6b
> "passthrough: make management of PCI D-states by guest optional".
> 
>   AR    i386-dm/libqemu.a
>   LINK  i386-dm/qemu-dm
>   pass-through.o: In function `register_real_device':
>   
> /home/horms/projects/xen/hg/xen-unstable.hg/tools/ioemu-dir/hw/pass-through.c:3655:
>   undefined reference to `direct_pci_power_mgmt'
>   collect2: ld returned 1 exit status
> 
> direct_pci_power_mgmt does exist in ./xenstore.c,
> but I guess that ./xenstore.o isn't being linked in at this point,
> possibly because its in the parent directory of hw/pass-through.c
> 
> -- 
> Simon Horman
>   VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
>   H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel

$ touch xenstore.c; make -n
=== PCI passthrough capability has been enabled ===
make -C i386-dm V="" TARGET_DIR="i386-dm/" all
=== PCI passthrough capability has been enabled ===
=== PCI passthrough capability has been enabled ===
make[1]: Entering directory `/home/kouya/qemu-xen-unstable.git/i386-dm'
echo "  CC    i386-dm/xenstore.o" && gcc -I. -I.. 
-I/home/kouya/xen-unstable.hg/tools/ioemu-dir/target-i386 
-I/home/kouya/xen-unstable.hg/tools/ioemu-dir -MMD -MT xenstore.o -MP 
-DNEED_CPU_H -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 -D_LARGEFILE_SOURCE 
-I/home/kouya/xen-unstable.hg/tools/ioemu-dir/tcg 
-I/home/kouya/xen-unstable.hg/tools/ioemu-dir/tcg/x86_64 
-I/home/kouya/xen-unstable.hg/tools/ioemu-dir/fpu  
-I/home/kouya/xen-unstable.hg//tools/libxc 
-I/home/kouya/xen-unstable.hg//tools/xenstore 
-I/home/kouya/xen-unstable.hg//tools/include 
-I/home/kouya/xen-unstable.hg//tools/blktap/lib -O2 -g -fno-strict-aliasing 
-Wall -Wundef -Wendif-labels -Wwrite-strings -Wmissing-prototypes 
-Wstrict-prototypes -Wredundant-decls -O1 -fno-omit-frame-pointer 
-fno-optimize-sibling-calls -m64 -g -fno-strict-aliasing -std=gnu99 -Wall 
-Wstrict-prototypes -Wno-unused-value -Wdeclaration-after-statement  
-D__XEN_TOOLS__ -MMD -MF .xenstore.o.d  -D_LARGEFILE_SOURCE 
-D_LARGEFILE64_SOURCE  -Wno-unused -Wno-declaration-after-statement 
-Wno-pointer-sign  -DCONFIG_PASSTHROUGH  -I../hw  -m64 -Wno-unused 
-Wno-declaration-after-statement -Wno-pointer-sign  -DCONFIG_PASSTHROUGH  -c -o 
xenstore.o /home/kouya/xen-unstable.hg/tools/ioemu-dir/xenstore.c
echo "  LINK  i386-dm/qemu-dm" && gcc -O2 -g -fno-strict-aliasing -Wall -Wundef 
-Wendif-labels -Wwrite-strings -Wmissing-prototypes -Wstrict-prototypes 
-Wredundant-decls -O1 -fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 
-g -fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value 
-Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF ..d  
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -Wno-unused 
-Wno-declaration-after-statement -Wno-pointer-sign  -DCONFIG_PASSTHROUGH  
-I../hw  -m64 -Wno-unused -Wno-declaration-after-statement -Wno-pointer-sign  
-O2 -g -fno-strict-aliasing -Wall -Wundef -Wendif-labels -Wwrite-strings 
-Wmissing-prototypes -Wstrict-prototypes -Wredundant-decls -O1 
-fno-omit-frame-pointer -fno-optimize-sibling-calls -m64 -g 
-fno-strict-aliasing -std=gnu99 -Wall -Wstrict-prototypes -Wno-unused-value 
-Wdeclaration-after-statement  -D__XEN_TOOLS__ -MMD -MF ..d  
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE  -Wno-unused 
-Wno-declaration-after-statement -Wno-pointer-sign  -g -Wl,--warn-common     
-m64 -o qemu-dm vl.o /home/kouya/xen-unstable.hg/tools/ioemu-dir/osdep.o 
monitor.o pci.o loader.o isa_mmio.o machine.o virtio.o virtio-blk.o 
virtio-net.o virtio-console.o fw_cfg.o 
/home/kouya/xen-unstable.hg/tools/ioemu-dir/posix-aio-compat.o 
/home/kouya/xen-unstable.hg/tools/ioemu-dir/block-raw-posix.o lsi53c895a.o 
esp.o usb-ohci.o eeprom93xx.o eepro100.o ne2000.o pcnet.o rtl8139.o e1000.o 
ide.o pckbd.o ps2.o vga.o dma.o fdc.o mc146818rtc.o serial.o i8259.o i8254.o 
pc.o cirrus_vga.o parallel.o piix_pci.o usb-uhci.o hpet.o piix4acpi.o 
xenstore.o xen_platform.o xen_machine_fv.o xen_machine_pv.o xen_backend.o 
xenfb.o xen_console.o exec-dm.o pci_emulation.o helper2.o battery_mgmt.o 
xen_blktap.o tpm_tis.o pass-through.o pt-msi.o ../libqemu_common.a libqemu.a  
-lm -lz  -lgnutls   -lpthread -lrt -lutil 
-L/home/kouya/xen-unstable.hg//tools/libxc -lxenctrl -lxenguest 
-L/home/kouya/xen-unstable.hg//tools/xenstore -lxenstore 
-L/home/kouya/xen-unstable.hg//tools/blktap/lib -lblktap -lpci -L/usr/lib64 
-lSDL -lpthread -lXext -lGL  -lncurses  
make[1]: Leaving directory `/home/kouya/qemu-xen-unstable.git/i386-dm'

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel