RE: [Xen-devel] [PATCH 4/5] use uint32_t for xen_domid

[Dan Magenheimer <dan.magenheimer@xxxxxxxxxx>]

May not matter but isn't a domid limited to 16-bits
in the hypervisor?  Probably should be consistent
lest sign-extension or something cause a problem.

> -----Original Message-----
> From: Gerd Hoffmann [mailto:kraxel@xxxxxxxxxx]
> Sent: Friday, March 20, 2009 10:03 AM
> To: xen-devel@xxxxxxxxxxxxxxxxxxx
> Cc: Ian.Jackson@xxxxxxxxxxxxx; Gerd Hoffmann;
> stefano.stabellini@xxxxxxxxxxxxx
> Subject: [Xen-devel] [PATCH 4/5] use uint32_t for xen_domid
> 
> 
> 
> Signed-off-by: Gerd Hoffmann <kraxel@xxxxxxxxxx>
> ---
>  hw/xen.h            |    2 +-
>  hw/xen_machine_pv.c |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/hw/xen.h b/hw/xen.h
> index 4bcc0f1..3c8da41 100644
> --- a/hw/xen.h
> +++ b/hw/xen.h
> @@ -14,7 +14,7 @@ enum xen_mode {
>      XEN_ATTACH        // attach to xen domain created by xend
>  };
>  
> -extern int xen_domid;
> +extern uint32_t xen_domid;
>  extern enum xen_mode xen_mode;
>  
>  #endif /* QEMU_HW_XEN_H */
> diff --git a/hw/xen_machine_pv.c b/hw/xen_machine_pv.c
> index df28be9..6525856 100644
> --- a/hw/xen_machine_pv.c
> +++ b/hw/xen_machine_pv.c
> @@ -28,7 +28,7 @@
>  #include "boards.h"
>  #include "xen_backend.h"
>  
> -int xen_domid;
> +uint32_t xen_domid;
>  enum xen_mode xen_mode = XEN_EMULATE;
>  
>  extern void init_blktap(void);
> -- 
> 1.6.1.3
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel