[Xen-devel] Re: [patch] HVM: Expand the number of PCI interrupts from 16 to 32

[Simon Horman <horms@xxxxxxxxxxxx>]

On Mon, Mar 09, 2009 at 09:17:30AM +0000, Keir Fraser wrote:
> On 08/03/2009 23:48, "Simon Horman" <horms@xxxxxxxxxxxx> wrote:
> 
> > I'm not sure what the reason for this, but the tables relating
> > to PCI interrupts seem to be truncated to 15 entries. I am
> > guessing that they are just incomplete and that this has never
> > been an issue. This patch extends these tables to the full 32 entries.
> > 
> > Tested by giving an ioemu rtl8139 device pci device 24,
> > which is unable to communicate with the network without this change.
> 
> The rombios.c change was optimistic (you changed the bytes-per-device value,
> rather than the number-of-devices value). The rombios table actually already
> only describes 6 PCI devices, and expanding it further may risk overflowing
> the available space in the ROM image. Any OS we pass devices to is going to
> be ACPI-enabled anyway, so it doesn't matter.
> 
> The DSDT changes had some bugs -- the LNK[ABCD] values were mostly wrong,
> and the GSI values for Device 23 Links C&D were wrong.

Thanks, sorry for the misses.

-- 
Simon Horman
  VA Linux Systems Japan K.K., Sydney, Australia Satellite Office
  H: www.vergenet.net/~horms/             W: www.valinux.co.jp/en


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel