RE: [Xen-devel] [XENOPROFILE] Xenoprof passive profiling broken undercs 13062

["Santos, Jose Renato G" <joserenato.santos@xxxxxx>]

> -----Original Message-----
> From: Ray Bryant [mailto:raybry@xxxxxxxxxxxxxxxxx] 
> Sent: Monday, December 18, 2006 10:07 AM
> To: Santos, Jose Renato G
> Cc: Isaku Yamahata; xen-devel@xxxxxxxxxxxxxxxxxxx; Woller, Thomas
> Subject: Re: [Xen-devel] [XENOPROFILE] Xenoprof passive 
> profiling broken undercs 13062
> 
> On Saturday 16 December 2006 03:24, Santos, Jose Renato G wrote:
> > Ray,
> >
> > Try this patch
> >
> > Please let me know if it fixes the problem
> >
> > BTW, I have now xen running on a AMD machine with SVM support here.
> > I did some tests with 64bit PV guests but have not tried hvm guests 
> > yet What is the status of profiling HVM guests? Are you 
> still having 
> > problems?
> > If you are still having problems I can try to reproduce the problem 
> > here...
> >
> > Regards
> >
> > Renato
> 
> Yes, that patch appears to fix the problem.   I'm surprised, 
> though, as the 
> test appears to be backwards from what I thought 
> "shadow_mode_translate()" 

  The problem is that we map xenoprof buffer for the passive hvm guest
  into dom0 and not into the guest since dom0 collects the profile
samples
  for the passive guest. The code was checking the mode for the guest
which is
  irrelevant; it should check the mode for dom0 (or coordinator) which
is
  mapping the buffer.
  With the provided patch, "shadow_mode_translate()" should now be
false,
  as expected, since it is now checking dom0 mode.
  
  
> returned.
> 
> WRT profiling HVM guests:  with oprofile-0.9.2 plus your 
> oprofile-0.9.2-xen.patch, it appears to work OK on an AMD 
> RevG.  I haven't tried it on other processors yet.
> 
  Good. Nice to hear that

  Regards

  Renato

> --
> Ray Bryant
> AMD Performance Labs                   Austin, Tx
> 512-602-0038 (o)                 512-507-7807 (c)
> 
> 
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel