[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [Patch] cleanup pciback_reset_device

  • To: Akio Takebe <takebe_akio@xxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Mon, 18 Dec 2006 09:33:33 +0000
  • Delivery-date: Mon, 18 Dec 2006 01:33:11 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Accih5Wm1AapU456Edui4wANk04WTA==
  • Thread-topic: [Xen-devel] [Patch] cleanup pciback_reset_device

On 18/12/06 9:21 am, "Akio Takebe" <takebe_akio@xxxxxxxxxxxxxx> wrote:

> This patch is for cleanup of pciback_reset_device.
> is_enabled=0 and is_busmaster=0 are not necessary
> because pci_disable_device() do them.

If you are zapping the command register then doesn't it makes sense to zap
the software flags relating to that at the same time, even if that sometimes
happens to be redundant? It certainly means we can be sure they won't get
out of sync.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.