[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Re: [Xen-devel] Re: [PATCH 2/2] PV framebuffer

On 14/12/06 12:37, "Markus Armbruster" <armbru@xxxxxxxxxx> wrote:

>> The lock is used in fb_ops, vm_ops and kthread contexts. None of these are
>> executed in IRQ context so irqsave is not needed. I'll remove it. I'm not
>> sure whether you can call zap_page_range() even with a spinlock held
>> though...
>>  -- Keir
> You can't.  This was spotted just yesterday in our internal review.
> I'm working on a fix.  If you could hold the removal of irqsave for a
> bit, that would avoid merge conflicts.

Too late I'm afraid.

If you come up with a reasonable fix before 3.0.4 goes out it'd be nice to
slip a fix in if it's not too big.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.