[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] fix multicall state tracking

  • To: Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <keir@xxxxxxxxxxxxx>
  • Date: Thu, 14 Dec 2006 10:36:16 +0000
  • Delivery-date: Thu, 14 Dec 2006 02:36:21 -0800
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Accfa67r7aLb6oteEdu2MgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] fix multicall state tracking

On 12/12/06 13:30, "Jan Beulich" <jbeulich@xxxxxxxxxx> wrote:

> This replaces the previous fix to multicall state tracking so that now the
> multicall-
> in-progress status is maintained on a per-VCPU basis (all other state remains
> per physical CPU). This seems cleaner than the previous hack requiring
> clearing
> of the flags in domain_crash_synchronous().
> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>

I decided to entirely move away from domain_crash_synchronous() in hypercall
context. So the code in domain_crash_synchronous() is just a warning for
errant code -- later it can become BUG_ON(). This means that multicall state
can remain per-cpu, unless per-vcpu seems much better (personally I think it
doesn't really matter either way so we may as well stick with what we have).

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.