[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Scrub VNC passwords from XenD log files

On Wed, Dec 06, 2006 at 05:24:36PM +0000, Ewan Mellor wrote:
> On Wed, Dec 06, 2006 at 05:16:03PM +0000, Daniel P. Berrange wrote:
> > I didn't add the signed-off-by because the patch isn't finished - I really 
> > just wanted to see if people were amenable to this kind of approach before
> > doing more work on it. Since you like it, I'll finish it off shortly - there
> > just a couple more test cases I need to go through - suspend/restore & 
> > inactive
> > domains - to verify passwords are always scrubbed correctly. I'll post a 
> > final
> > version of the patch by the end of today if all goes to plan.
> Great, thanks.  I think you're right that this is the best of all the
> available options, fiddly though it is.  Perhaps we could write a final check
> at the end of xm-test, to make sure that "vncpasswd" doesn't appear in the
> logs anywhere -- that would make sure that this never regresses.

Attached is a final version of the patch to scrub passwords. I have tested
it with HVM guests, and parvirt guests, using 'start', 'new', 'create',
'suspend', 'resume' commands to XM. In all cases, no password was present
to the XenD log files created.

  Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Attachment: xen-3.0.4-scrub-passwords-2.patch
Description: Text document

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.