[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 0/6] printk log level and print rate.

  • To: Steven Rostedt <srostedt@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Fri, 27 Oct 2006 08:59:18 +0100
  • Delivery-date: Fri, 27 Oct 2006 01:11:04 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acb5nc2HDA6OF2WREduHzQANk04WTA==
  • Thread-topic: [PATCH 0/6] printk log level and print rate.

On 27/10/06 4:19 am, "Steven Rostedt" <srostedt@xxxxxxxxxx> wrote:

> The following is a rewrite of the printk log levels (plus the added
> print rate limit) as for Keir's suggestions.
> This touches a lot so please test.

Two comments so far:

1. The rate-limiting code cannot rely on 'jiffies'. It's not required to
provide that variable in Xen (powerpc doesn't). Use NOW() and divide it down
(it returns a 64-bit nanoseconds value).

2. oops_in_progress is a bit cheesy. The user should be able to silence all
guest logging if they want. Let's remove it from the first cut of these

But basically it looks good. Please re-send all the patches after your next
round of fixups and I'll probably apply them at that point.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.