[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 00/04] Kexec / Kdump: Release 20061023 (xen-unstable-11856)

On 23/10/06 10:05, "Magnus Damm" <magnus@xxxxxxxxxxxxx> wrote:

> 20060931 - Take XIV for xen-unstable-11296 posted by Simon Horman
> Enjoy!

A couple of comments on this patchset:

Firstly, the new public header file is nicely laid out and commented but
it'd be nice to add some comments to the KEXEC_TYPE_* definitions explaining
what they mean. Also the same for xen_kexec_image_t (what do
indirection_page and start_address mean?). As far as possible it would be
good to have an explanation of the Xen kexec interface that stands alone and
allows independent implementation to that interface (e.g., in Solaris) with
as little need to crib from other kexec implementations as possible. So, for
example, adding a short 'story board' comment explaining the sequence of
hypercalls that would be used to set up and execute a kdump or kexec would
be useful. It would be very hard to add *too many* helpful comments. :-)

Secondly, you appear to stuff over 1000 lines of code into the patches/
directory. What is that all about? Will it go away when we move to a more
recent Linux kernel (which would be an argument to hold off on merging until
we have done that)?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.