[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] [RESEND] remove redundent call to hvm_do_resume

  • To: "Li, Xin B" <xin.b.li@xxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Mon, 23 Oct 2006 11:51:08 +0100
  • Delivery-date: Mon, 23 Oct 2006 03:51:38 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acb0CVpf06Hxya4XT6uW1ULXYRyKAQCGO58QABu3EN4=
  • Thread-topic: [Xen-devel] [PATCH] [RESEND] remove redundent call to hvm_do_resume

On 22/10/06 22:38, "Li, Xin B" <xin.b.li@xxxxxxxxx> wrote:

> Remove redundant call to hvm_do_resume.
> In this patch IO event channels in qemu are used for IO done
> notification only, so we can simplify the event checking handling in
> hvm_do_resume.
> Besides current intr notification from qemu is complete meanless,
> because eithor it's done with an IO event, or acturally do thing since
> the new xen consumed event channel, we will find a better way to
> implement that functionality.

I like avoiding hvm_do_resume() on every vm entry, so I took that part of
the patch. The change to ioemu was odd -- there are other places that set
send_event to 1 (the code that adds IRQs to the PIC IRR). We know that code
is somewhat broken for SMP guests, but you *do* need to notify Xen when
interrupts happen, right?

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.