[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [HVM][SVM][PATCH][2/2] Delay ExtInt Injection

  • To: "Woller, Thomas" <thomas.woller@xxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Thu, 19 Oct 2006 23:10:29 +0100
  • Delivery-date: Thu, 19 Oct 2006 15:21:57 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acbzymi4P2KtNndXRqyvD4zGkvhIlwAAPozJ
  • Thread-topic: [Xen-devel] [HVM][SVM][PATCH][2/2] Delay ExtInt Injection

On 19/10/06 11:03 pm, "Woller, Thomas" <thomas.woller@xxxxxxx> wrote:

> Add flag to indicate that an exception event needs injecting, and to
> delay
> the ext interrupt injection.
> Remove unnecessary check of RFLAGS.IF for ExtInt injection.

Since EventInj is separate from V_IRQ, and both are supported simultaneously
(EventInj followed by V_IRQ, I hope!), why do you need to enforce mutual
exclusion favouring EventInj and delaying V_IRQ injection?

Removing the RFLAGS.IF check makes sense because the previous patch moves
the check later (and does dummy VIRQ injection instead of simply bailing).
But I don't see why the EventInj check gets added by this patch.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.