[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH 01/04] Kexec / Kdump: Generic code

On Mon, Oct 16, 2006 at 03:03:29PM +0100, Keir Fraser wrote:
> Some comments:
> No need for IO-APIC work on the guest side of the kexec interfaces (e.g.,
> don't call disable_IO_APIC()).
> What's the second argument to the hypercall for? There's no clear
> explanation of what the TYPE parameter means, and currently it is only ever
> specified as TYPE_CRASH. So what's TYPE_DEFAULT for? And do we really need
> to avoid copy_to/from_guest so it can't be folded into the structural
> parameter?

TYPE_DEFAULT is kexec, TYPE_CRASH is kdump.

Its just to avoid a from_guest. If you think that isn't worthwhile
we can fold it into the structural parameter.

> The comment attached to every use of xchg() is dubious. We don't specify
> warn_unused_result on that function so there's no good reason for the
> compiler to complain about discarding the result. If it's a reproducible
> problem it needs investigating. We shouldn't work around a broken compiler.

I certainly saw the problem. I'll do some more investigations.

... Actually now that I think about it for a moment, perhaps it was
inheriting -Wall from CFLAGS in my environment. If that is the case,
then I think the work-around I added is valid.:wq

> Attribution at the top of many files: 'Horms' is a bit vague. Could we have
> a full name? A company name? An email address?


  H: http://www.vergenet.net/~horms/
  W: http://www.valinux.co.jp/en/

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.