[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] Re: [PATCH] Error message for device not found at blkif.py

Glauber de Oliveira Costa wrote:
On Wed, Oct 18, 2006 at 03:59:30PM -0500, Anthony Liguori wrote:
Instead of throwing a VmError, could you subclass VmError with a more specific error and throw that?
Fore sure I can. But what does this condition have so differently from
others that justifies that for it only?

Good question. Previously, we only threw opaque errors back over the wire. A few months ago, we changed that so that we could pass exceptions over the wire with specific Fault ids. The new Xend API should be even better for this.

So, the answer we know have the ability to do useful things with this info so it's now a best practice for new code :-)

I'm not suggesting you go change everything, just in your patch.


Anthony Liguori

Although I agree with you that such a specificiness is good, VmError is being thrown everywhere, meaning that your proposal would require touching a great amount of code change.
Is there any plans/opposals for that?

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.