[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences.

  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Tue, 17 Oct 2006 16:09:22 +0100
  • Delivery-date: Tue, 17 Oct 2006 08:09:54 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acbx/jnHeBCLkl3xEduPAgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Introduce Makefile config fragments for OS-specific differences.

On 17/10/06 13:42, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

> -ifneq ($(debug),y)
> -# Optimisation flags are overridable
> -CFLAGS    ?= -O2 -fomit-frame-pointer
> -else
> -# Less than -O1 produces bad code and large stack frames
> -CFLAGS    ?= -O1 -fno-omit-frame-pointer
> -CFLAGS    += -g
> -endif

Generally this patch is fine, but does the above chunk have to be made
OS-specific? Does Solaris specifically have something against

Also, moving KERNEL_REPO/KERNELS/XKERNELS seems unnecessary. There are still
rules consuming those variables in the root Makefile, so leaving
KERNELS/XKERNELS nearby makes sense to me.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.