[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] [PATCH] Fix tools build on Solaris

  • To: John Levon <levon@xxxxxxxxxxxxxxxxx>
  • From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
  • Date: Tue, 17 Oct 2006 15:01:52 +0100
  • Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
  • Delivery-date: Tue, 17 Oct 2006 07:02:36 -0700
  • List-id: Xen developer discussion <xen-devel.lists.xensource.com>
  • Thread-index: Acbx9MvKCmFY0V3oEduPAgAX8io7RQ==
  • Thread-topic: [Xen-devel] [PATCH] Fix tools build on Solaris

On 17/10/06 14:39, "John Levon" <levon@xxxxxxxxxxxxxxxxx> wrote:

>> Can't you fold TOOL_CFLAGS into CFLAGS? Why do you need a separate variable:
>> does it break the hypervisor build?
> Yes. It's not at all clear why, but the -std=gnu99 causes:

Ah yes, C99 distinguishes initializers from expressions. The cast means that
the compiler interprets the assignment as non-constant. I think the default
mode (-std=gnu89) specifically allows this as a hack, mainly for Linux.
-std=gnu99 is likely to become standard option in future and it probably
wouldn't be hard to fix this.

 -- Keir

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.