[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Xen-devel] building blktap as a module





On 16/10/06 12:45, "Gerd Hoffmann" <kraxel@xxxxxxx> wrote:

>>  1. The one in blktap_release() - why? Standard semantics is for mmap
>> regions to exist beyond the closing of the mapping device. Doesn't make much
>> sense to do that here, but then again not really any need to explicitly
>> disallow it (and add extra code to enforce).
> 
> The linux kernel does call the drivers release() method when the last
> reference is gone.  If you call close() with mappings still being
> active, then ->release() is _not_ called when you close the file handle
> but when the last mapping is unmapped.  Thus there is no point in trying
> to handle active mappings there ;)

I.e., they'll have been unmapped already? As you say, either way the zap is
not needed...

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel


 


Rackspace

Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.