[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Xen-devel] [PATCH] always call SDL_Quit

When qemu-dm is using SDL and has the mouse captured, a "xm destroy" of the VM 
will cause control of the mouse to be lost.  This happens because the qemu-dm 
is killed with SIGKILL, so atexit doesn't run, so SDL_Quit doesn't run.  Other 
things could go wrong too -- for example, if the VM was fullscreen, the video 
mode probably wouldn't be reset either.

There was a discussion a few years ago on the SDL mailing list regarding the 
ramifications of not calling SDL_Quit.  In short, you don't want to skip it:

The attached patch sends a SIGTERM instead of SIGKILL.  I've been using a 
variation of this patch since our SLES 10 betas, and I've never seen a case 
where SIGKILL was actually needed.

Please apply.

Signed-off-by: Charles Coffing <ccoffing@xxxxxxxxxx>

Attachment: xen-lost-mouse.diff
Description: Binary data

Xen-devel mailing list



Lists.xenproject.org is hosted with RackSpace, monitoring our
servers 24x7x365 and backed by RackSpace's Fanatical Support®.